From 8c3afa67ee971d5decee863cee842c58bc5c5d34 Mon Sep 17 00:00:00 2001 From: Keir Fraser Date: Fri, 29 Jan 2010 08:59:46 +0000 Subject: [PATCH] tools/gtraceview: fix SIGFPE If there are 0 or 1 valid record in xentrace file, SIGFPE will occur. Fix it. Signed-off-by: Yu Zhiguo --- tools/misc/gtraceview.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/misc/gtraceview.c b/tools/misc/gtraceview.c index 52b7ae2846..3bfedad654 100644 --- a/tools/misc/gtraceview.c +++ b/tools/misc/gtraceview.c @@ -209,6 +209,11 @@ int main(int argc, char *argv[]) if (load_file(fname)) exit(EXIT_FAILURE); + if (!data_cur) { + fprintf(stderr, "file %s doesn't contain any valid record\n", fname); + exit(EXIT_FAILURE); + } + if (mode_init()) exit(EXIT_FAILURE); @@ -939,14 +944,15 @@ int time_mode_rebuild(uint64_t start_time, uint64_t time_scale) struct cpu cur_state[MAX_CPU_NR]; uint64_t tsc = start_time; struct state *state; - uint64_t number, temp; + uint64_t number, temp = 0; int state_cur = 0; for (i = 0; i < max_cpu_num; i++) cur_state[i].flag = FLAG_UNKNOWN; /* allocate spaces, it may be huge... */ - temp = (data[data_cur-1].tsc - start_time)/time_scale; + if (time_scale) + temp = (data[data_cur-1].tsc - start_time)/time_scale; number = 10000UL; if (temp < number) number = temp; -- 2.30.2